Format with Prettier

[mwojick-keeper]

These are the only real changes:
49df92e
3e58c4e

The rest is formatting from npm run format

The format commit (and others added to .git-blame-ignore-revs) can be ignored in the blame by running:
git config blame.ignoreRevsFile .git-blame-ignore-revs

[tylerccarson]

A few general thoughts here:

• prettier hasn't been added as a dev dependency, and no script has been added to format the project. If we're going to add a formatter, we should be giving devs a way to use it, and we should be enforcing it in CI.
• keeperapi is where we write the code for the actual package, I'd say focus on putting the .rc file, dep, and script there and don't worry about the examples directory since that's largely unmaintained
• I tried running blame locally, and that revs file doesn't get used automatically, which is unfortunate. If there's a way to do that so that we don't have to pass a flag / option, it would be more ideal

[mwojick-keeper]

A few general thoughts here:

• prettier hasn't been added as a dev dependency, and no script has been added to format the project. If we're going to add a formatter, we should be giving devs a way to use it, and we should be enforcing it in CI.
• keeperapi is where we write the code for the actual package, I'd say focus on putting the .rc file, dep, and script there and don't worry about the examples directory since that's largely unmaintained
• I tried running blame locally, and that revs file doesn't get used automatically, which is unfortunate. If there's a way to do that so that we don't have to pass a flag / option, it would be more ideal

Good points, will try to address all those. For the rev file, would it be ok to put the git config cmd in a postinstall script? or just add it to the readme?

[tylerccarson]

Good points, will try to address all those. For the rev file, would it be ok to put the git config cmd in a postinstall script? or just add it to the readme?

Readme probably best bet, sounds like it should be more of an opt-in thing but good to have a quick reference on how to do so

[tylerccarson]

@THeflinKeeper @saldoukhov wondering if you have any thoughts on these rules. Personally I'd be all for removing semi-colons to be a bit more modern 😄 , and I'm a big fan of keeping the 4 space tabWidth

[mwojick-keeper]

The only quirk with that is it creates ambiguity for when code statements end, like if you have a line starting with characters like [ or (, it makes you have to put a ; at the start of the line, or else it will be combined with the previous line. But it's pretty rare and if we are already not using semis in other repos then maybe it's better to just stay consistent.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	prettier@​3.8.1

View full report