Skip to content

Conversation

@imyxh
Copy link

@imyxh imyxh commented Oct 26, 2025

Add initial support for the OpenSSL EVP_DigestSign interface, as per #49. At least RSA signing should work now. Also tidy up some stuff (closes #28 on the side).

imyxh added 6 commits October 19, 2025 06:49
this is in preparation for adding signature support in the digests
section
but doesn't seem to be working properly yet ...
- exports now listed in file order and grouped by relevance
- removed undefined exports (TLSv12ClientMethod, TLSv12ServerMethod, read)
- removed EvpMD2 and EvpDSS1 which don't correspond to openssl symbols
    - closes JuliaWeb#28
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.69%. Comparing base (10f7b7b) to head (3c04503).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenSSL.jl 86.66% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   77.56%   74.69%   -2.87%     
==========================================
  Files           2        2              
  Lines        1083     1075       -8     
==========================================
- Hits          840      803      -37     
- Misses        243      272      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imyxh
Copy link
Author

imyxh commented Oct 26, 2025

I don't know what's going on with the nightly tests but I don't think they're my fault. As for lts, do we want to support OpenSSL v1 still? EVP_DigestSignUpdate() was converted from a macro to a function in OpenSSL 3.0. I can try to support pre-v3 by switching on the openssl version and just calling DigestUpdate instead, but personally I find this a bit cursed. OpenSSL v3 is stable in virtually every environment known to man.

@aviks
Copy link
Member

aviks commented Nov 29, 2025

I can try to support pre-v3 by switching on the openssl version

I don't think we have consensus on dropping v1, so maybe you can throw some kind of not-implemented exception at the very least?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not load symbol "EVP_md2"

2 participants