Improve Github Action for testing various combinations of ruby/faraday/active[support|model]#415
Open
LeipeLeon wants to merge 7 commits intoJsonApiClient:masterfrom
Open
Improve Github Action for testing various combinations of ruby/faraday/active[support|model]#415LeipeLeon wants to merge 7 commits intoJsonApiClient:masterfrom
LeipeLeon wants to merge 7 commits intoJsonApiClient:masterfrom
Conversation
- setup matrix for all major.minor versions of activesupport/activemodel >= 6 - run these against both versions of faraday
- run tests w/ the generated gemfiles so when a ruby version fails it's shown as a separate failure in GHA
…ger (NameError) `concurrent-ruby` v1.3.5 has removed the dependency on logger` > require logger and leave concurrent-ruby version unlocked. This is primarily an issue for older Rails 7.0 and 6.1. ruby-concurrency/concurrent-ruby@d7ce956 See: https://stackoverflow.com/questions/79360526/uninitialized-constant-activesupportloggerthreadsafelevellogger-nameerror
``` /home/runner/work/json_api_client/json_api_client/gemfiles/vendor/bundle/ruby/3.4.0/gems/activesupport-6.0.6.1/lib/active_support/notifications/fanout.rb:3: warning: mutex_m was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add mutex_m to your Gemfile or gemspec to silence this warning. /home/runner/work/json_api_client/json_api_client/gemfiles/vendor/bundle/ruby/3.4.0/gems/webmock-3.5.1/lib/webmock/util/headers.rb:1: warning: base64 was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add base64 to your Gemfile or gemspec to silence this warning. ```
as done on my machine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty to update the Github action to improve the tests.
Also made these decisions:
active[support|model]>= 6active[support|model]ruby: 3.0, 3.1, 3.2, 3.3, 3.4rubytest passes run all combinations ofruby/faraday/active[support|model]ruby: 3.0, 3.1, 3.2, 3.3, 3.4faraday: 1.x, 2.xactivesupport/activemodel: 6.0, 6.1, 7.0, 7.1 ,7.2, 8.0activesupport ~> 7.2.0depends on Ruby >= 3.1.0activesupport ~> 8.0.0depends on Ruby >= 3.2.0mutex_mandbase64to the development dependencies to make tests pass.