Fix Warnings raised during compilation#505
Merged
JeanPhilippeKernel merged 1 commit intoJeanPhilippeKernel:developfrom Mar 5, 2026
Merged
Fix Warnings raised during compilation#505JeanPhilippeKernel merged 1 commit intoJeanPhilippeKernel:developfrom
JeanPhilippeKernel merged 1 commit intoJeanPhilippeKernel:developfrom
Conversation
- use String version of ImGui calls in DockspaceUIComponent - Change Handle::Index from uint32_t to uint64_t because it is we are using it to represent a void* and as we are generally targeting x64 the system would warn about this conversion. - Used static_casts to deal with enum-to-enum comparisons using different enum types. - return default typed Node in Messenger.h - Close off switch statements with a default clause.
JeanPhilippeKernel
approved these changes
Mar 5, 2026
JeanPhilippeKernel
merged commit 27ab2f4
into
JeanPhilippeKernel:develop
21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted to fix the warnings that would persistently come up when compiling. These are possibly a source of bugs.
Changes made include:j