This repository was archived by the owner on Mar 9, 2020. It is now read-only.
Open
Conversation
Adapted Martin Trummer's named cell validation code from https://github.com/MartinTrummer/excel-names to fix bug JanKallman#449
Added the correct validity ranges for characters that can be used as starting characters and characters that can be used after start.
|
Any updates on this going into a release anytime soon? |
Author
|
I added a few more commits to resolve a bug in how I was making a call to a function, and also to change how I was clearing stringbuilder to make it compatible with .NET3.5 and earlier.
…On Fri, Oct 18, 2019 at 1:07 AM joonsaepark ***@***.***> wrote:
Any updates on this going into a release anytime soon?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#529?email_source=notifications&email_token=AI75NPP6JZW6ADPEMTCZEELQPCETXA5CNFSM4IPN32QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQUUZY#issuecomment-543246951>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI75NPODKWCO4RN7HFGVVELQPCETXANCNFSM4IPN32QA>
.
|
Reversed the logic on call to IsValidAddress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The named cells validation code which was introduced in 4.5.3 does not properly implement Unicode characters which are valid from those which are not. I've updated validation rules for named cells based on VB code adapted from Martin Trummer's named cell validation rules https://github.com/MartinTrummer/excel-names to fix bug #449