This repository was archived by the owner on Mar 5, 2019. It is now read-only.
Capistrano subdir configuration#155
Open
JohnSmall wants to merge 7 commits intoHackBrexit:capistrano_subdir_configurationfrom
Open
Capistrano subdir configuration#155JohnSmall wants to merge 7 commits intoHackBrexit:capistrano_subdir_configurationfrom
JohnSmall wants to merge 7 commits intoHackBrexit:capistrano_subdir_configurationfrom
Conversation
added 7 commits
February 4, 2017 19:49
houndci-bot
reviewed
Feb 19, 2017
| # used to set extended properties on the server. | ||
| set :domain,YAML.load_file('config/deploy.yml')[fetch(:stage)][:domain] | ||
| server fetch(:domain), user: 'ubuntu', roles: %w{db web app}#, my_property: :my_value | ||
| server fetch(:domain), user: 'rails', roles: %w{db web app}#, my_property: :my_value |
There was a problem hiding this comment.
%w-literals should be delimited by ( and ).
Missing space after #.
Put a space before an end-of-line comment.
Line is too long. [84/80]
|
|
||
| # Default value for :linked_files is [] | ||
| set :linked_files, ['config/database.yml','config/secrets.yml','config/deploy.yml','config/environment_params.yml'] | ||
| set :linked_files, ['config/database.yml','config/secrets.yml','config/environment_params.yml'] |
There was a problem hiding this comment.
Space missing after comma.
Line is too long. [95/80]
| @@ -1,4 +1,8 @@ | |||
| # config valid only for Capistrano 3.1 | |||
| # See http://stackoverflow.com/questions/29168/deploying-a-git-subdirectory-in-capistrano/6969505#6969505 for instructions on how | |||
Member
|
@JohnSmall could you make the houndci-bot changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Pull Request should relate to a single feature, therefore a single Issue. The smaller the Pull Request the faster it can be reviewed & merged. It should not be merged by the author.
Issues to close
Fixes #133
Notes
Notes on the Pull Request.
This holds the configurations required to run the Rails app behind Nginx and Phusion Passenger using deployment from a sub-tree in this case src/ruby/meetings
Requires a properly configured instance to deploy into. See my comment on #133
Once there's a fully configured instance in place then cd into src/ruby/meetings and run
cap production deploy:first_timeWhich will set things up correctly, though I'll have to edit the production Nginx configuration file
It's best if I do that first step. After that all deploys become simply
cap production deployTasks
Once merged to master, I'll do the first deployment and wire up Nginx to make the site visible. After that anyone can deploy