feat(fabric): proxy plugin message channel #2379
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: remove debug message
ManInMyVan
requested changes
Nov 29, 2025
fabric/mc1218/src/main/java/ac/grim/grimac/platform/fabric/mc1218/Fabric1218PlatformServer.java
Outdated
Show resolved
Hide resolved
fabric/src/main/java/ac/grim/grimac/platform/fabric/GrimACFabricEntryPoint.java
Show resolved
Hide resolved
fabric/src/main/java/ac/grim/grimac/platform/fabric/GrimACFabricLoaderPlugin.java
Show resolved
Hide resolved
fabric/src/main/java/ac/grim/grimac/platform/fabric/FabricPlatformPlugin.java
Show resolved
Hide resolved
chore: remove cleanup code
…er/Grim into feat-proxy-plugin-message-channel
Contributor
|
Is there a reason you're handling version specific code yourself for sending this packet instead of just using a PacketEvents wrappers? |
Contributor
Author
|
PacketEvents didn't work correctly. I tried it, but it sent the wrong packet (possibly a mismatched packet ID). |
Contributor
The less platform-specific code in Grim the better How are you sending it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added fabric support for the plugin-message-channel over velocity/bungeecord.
In version 1.21.8 the
CustomPayloadPacketwas changed, so I added a new sub-project named fabric/mc1218.Key changes:
usingProxytotrueon fabric serversfabric networking apito support 1.21.8This has been tested on version 1.21.10 (ATM).