feat(desktop): add --list-gpu-adapters CLI flag #3529
+34
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new CLI flag to list available GPU adapters and exit - Refactor gpu_context.rs to eliminate code duplication - Extract create_context_builder() helper function - Add documentation for public functions - Define ADAPTER_ENV_VAR constant for environment variable name - Remove verbose adapter logging on every startup Resolves TODO comments about adding CLI flag for adapter listing.
TrueDoctor
reviewed
Dec 25, 2025
desktop/src/lib.rs
Outdated
| let wgpu_context = futures::executor::block_on(gpu_context::create_wgpu_context()); | ||
| if cli.list_gpu_adapters { | ||
| futures::executor::block_on(gpu_context::list_adapters()); | ||
| exit(0); |
Member
There was a problem hiding this comment.
I'd prefer a return instead of an exit() since the exit does not do any cleanup
Author
There was a problem hiding this comment.
Good catch, thanks! Changed to return so the lock and any other initialized resources get properly cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves TODO comments about adding CLI flag for adapter listing.