Make pdf edge-to-edge and add logic to dodge window insets#588
Open
hunterstich wants to merge 2 commits intoGrapheneOS:mainfrom
Open
Make pdf edge-to-edge and add logic to dodge window insets#588hunterstich wants to merge 2 commits intoGrapheneOS:mainfrom
hunterstich wants to merge 2 commits intoGrapheneOS:mainfrom
Conversation
inthewaves
suggested changes
Mar 4, 2026
Member
|
Actually, I just noticed #538 which seems to be more fleshed out (though marked as a draft) |
Member
|
I planned on submitting more changes along with #538 for review |
Member
|
The text layer alignment is fragile with the current approach. So, upcoming PDF.js updates and changes to code often breaks it. #538 also aims to improve the overall architecture by introducing a page element. |
Author
|
@octocorvus oh nice! Yea, just updated this PR to fix the text layer but it feels somewhat brittle. Having a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 This change makes the PDF WebView always edge-to-edge, avoiding any jumps in the pdf's location on screen when hiding/showing system insets or app UI.
Resolves #273.
The AppBarLayout's show/hide animation could still be improved if that's something the project would like!
Summary:
WindowCompat#enableEdgeToEdge(window)to make WebView draw behind insets.enableEdgeToEdgeinternally callsWindowCompat#setDecorFitsSystemWindows(window, false)which can be removedBefore:
before_.pixel5_api34_withCameraHolePunch_480.mov
After:
after_pixel2_api28_480.mov
after_pixel5_api34_wCameraHolePunch_480.mov