-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat: Updated video/live-stream Python Samples to add features and more information from the API #13683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Updated video/live-stream Python Samples to add features and more information from the API #13683
Conversation
…s as returned by the API and add some additional arguments to enable further configuration parameters
Summary of ChangesHello @chrishampart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Python samples for the Live Stream API by addressing argument handling inconsistencies and substantially enriching the output of 'get' and 'list' operations. It also introduces new capabilities for creating inputs with specified types and updating channel logging configurations, making the samples more robust and informative for users interacting with the API. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several features and fixes to the Live Stream API Python samples. It correctly handles input_id arguments, adds options for input_type and log_config, and expands the information displayed by the get and list samples. The changes are a significant improvement. I've identified one likely bug where a variable is used as a string literal and one minor maintainability issue related to variable naming. Addressing these will further improve the quality of the samples.
Set key to be the value of input_id variable rather than the strong literal "input_id" Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Made two fixes and added several features to the Live Stream API Python samples as follows:
Fixed video/live-stream/create_channel.py so that it correctly reads from the --input_id argument.
Added a feature to video/live-stream/create_input.py so that --input_type can be optionally used as an argument to set the input-type on the input being created.
Added features to video/live-stream/get_channel.py so that additional fields returned by the API are displayed in the output.
Added features to video/live-stream/get_input.py so that additional fields returned by the API are displayed in the output.
Added features to video/live-stream/list_channels.py so that additional fields returned by the API are displayed in the output.
Fixed video/live-stream/update_channel.py so that it correctly reads from the --input_id argument.
Added feature to video/live-stream/update_channel.py so that --log_config can optionally by used as an argument to set the log_severity / log level for the channel.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)