Skip to content

Conversation

@chrishampart
Copy link

Description

Made two fixes and added several features to the Live Stream API Python samples as follows:

Fixed video/live-stream/create_channel.py so that it correctly reads from the --input_id argument.
Added a feature to video/live-stream/create_input.py so that --input_type can be optionally used as an argument to set the input-type on the input being created.
Added features to video/live-stream/get_channel.py so that additional fields returned by the API are displayed in the output.
Added features to video/live-stream/get_input.py so that additional fields returned by the API are displayed in the output.
Added features to video/live-stream/list_channels.py so that additional fields returned by the API are displayed in the output.
Fixed video/live-stream/update_channel.py so that it correctly reads from the --input_id argument.
Added feature to video/live-stream/update_channel.py so that --log_config can optionally by used as an argument to set the log_severity / log level for the channel.

Checklist

…s as returned by the API and add some additional arguments to enable further configuration parameters
@chrishampart chrishampart requested review from a team as code owners December 29, 2025 17:28
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 29, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chrishampart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Python samples for the Live Stream API by addressing argument handling inconsistencies and substantially enriching the output of 'get' and 'list' operations. It also introduces new capabilities for creating inputs with specified types and updating channel logging configurations, making the samples more robust and informative for users interacting with the API.

Highlights

  • Input ID Fixes: Corrected create_channel.py and update_channel.py to properly utilize the --input_id argument for input attachments, resolving previous hardcoded values.
  • Configurable Input Type: Enhanced create_input.py to allow specifying the input type (e.g., RTMP_PUSH, SRT_PUSH) via an optional --input_type command-line argument.
  • Expanded Channel Information: Significantly augmented get_channel.py and list_channels.py to display a broader range of details returned by the Live Stream API, including creation/update times, streaming state, errors, input attachments, output URIs, log configurations, and stream definitions.
  • Detailed Input Information: Improved get_input.py to output more comprehensive information about an input, such as its type, tier, and URI.
  • Configurable Channel Logging: Added an optional --log_config argument to update_channel.py, enabling users to set the log severity level for a channel.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several features and fixes to the Live Stream API Python samples. It correctly handles input_id arguments, adds options for input_type and log_config, and expands the information displayed by the get and list samples. The changes are a significant improvement. I've identified one likely bug where a variable is used as a string literal and one minor maintainability issue related to variable naming. Addressing these will further improve the quality of the samples.

Set key to be the value of input_id variable rather than the strong literal "input_id"

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant