Install and use gnupg instead of deprecated apt-key to fix RStudio init on newer Debian images.

[NavdeepCS]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @NavdeepCS, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue preventing RStudio from initializing on newer Debian and Ubuntu images. It updates the method for importing repository keys from the deprecated apt-key utility to a more secure and current gnupg-based process, ensuring continued functionality and system integrity.

Highlights

• Deprecated apt-key replacement: The apt-key command, which is deprecated and removed in newer Debian/Ubuntu versions (e.g., Debian 13), has been replaced with a gnupg-based approach for importing the RStudio repository key. This ensures RStudio can be initialized correctly on modern systems.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• rstudio/rstudio.sh
  • Replaced the apt-key adv command with a sequence of apt-get update, apt-get install gnupg, gpg --keyserver --recv-keys, and gpg --export to handle repository key imports.
  • Added explicit installation of gnupg to ensure the necessary tool is available for key management.
  • Ensured the RStudio repository key is exported to /etc/apt/trusted.gpg.d/rstudio.asc for proper system-wide trust.

Activity

• No human activity has been recorded on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the deprecation of apt-key on newer Debian-based systems by switching to gnupg for managing APT repository keys. This is an important fix for compatibility. I've provided one suggestion to improve the implementation by using a temporary GPG home directory and correcting the key file extension, which will make the script more robust and correct.

[gemini-code-assist]

There are a couple of improvements that can be made to the GPG key handling:

1. Correct file extension: The gpg --export command produces a key in binary format. Files with binary GPG keys should have a .gpg extension. The current code saves it as .asc, which is reserved for ASCII-armored keys. This mismatch can cause apt to ignore the key.
2. Isolate GPG environment: The current commands modify the root user's default GPG keyring (/root/.gnupg). It's a better practice to use a temporary, isolated GPG home directory for these operations to avoid side effects on the system's GPG configuration.

The suggested code below addresses both of these points for a more robust and correct implementation.

Suggested change

	run_with_retries gpg --keyserver keyserver.ubuntu.com --recv-keys ${REPOSITORY_KEY}
	gpg --export ${REPOSITORY_KEY} \
	| tee /etc/apt/trusted.gpg.d/rstudio.asc >/dev/null
	TMP_GPG_HOMEDIR=$(mktemp -d)
	chmod 700 "${TMP_GPG_HOMEDIR}"
	run_with_retries gpg --homedir "${TMP_GPG_HOMEDIR}" --keyserver keyserver.ubuntu.com --recv-keys "${REPOSITORY_KEY}"
	gpg --homedir "${TMP_GPG_HOMEDIR}" --export "${REPOSITORY_KEY}" | tee /etc/apt/trusted.gpg.d/rstudio.gpg >/dev/null
	rm -rf "${TMP_GPG_HOMEDIR}"

[cjac]

_ No description provided. _

Hi there! Thanks for the contribution!

Can you compare and contrast with the examples in this function and let me know what you think? I think that we still need to create a canonical apt/dnf repo setup function.

https://github.com/LLC-Technologies-Collier/initialization-actions/blob/aecceacd715944c34533a01c13af13c014c64a77/gpu/install_gpu_driver.sh#L2860

My dream is to have all of the init actions generated from templates. We would have a template containing functions related to system package management. We could probably also generalize the patterns into management of other package sets such as npm, cpanm, gem, mvn, zef, cargo, php composer, go get, nuget, pip, etc.