Handle missing RDPVersion numbers thrown by some RDP clients#477
Open
luciaprime54 wants to merge 1 commit intoGoSecure:mainfrom
Open
Handle missing RDPVersion numbers thrown by some RDP clients#477luciaprime54 wants to merge 1 commit intoGoSecure:mainfrom
luciaprime54 wants to merge 1 commit intoGoSecure:mainfrom
Conversation
|
This PR is attempt to address #475. Unfortunately, it doesn't help me: I'm getting errors and disconnection on the Windows 11 target host (see Event Viewer) and connection timeout at the Windows 11 mstsc client on the other side. |
|
Can confirm this issue, it's the Windows 11 client that causes the problem. Using an older client OS this error does not apply. Edit: can confirm that this patch works too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent update of some clients such as Remmina on Linux recently updated the RDP version code to
0x80011and threw an exception crashing unnecessarily.Rather than waiting to hardcode the next version number, handle the ones we need to and create a catch-all for the ones we haven't seen.
PR also adds the latest version I saw in the wild:
0x80011