feat: add Button component and styles #2914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
arnautov-anton and
oliverlaz
as code owners
|
Size Change: +638 B (+0.22%) Total Size: 290 kB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Jan 14, 2026
Co-authored-by: Oliver Lazoroski <[email protected]>
MartinCupela
force-pushed
the
feat/add-generic-button
branch
from
ea082d9 to
9ced247
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2914 +/- ##
==========================================
+ Coverage 80.02% 80.13% +0.11%
==========================================
Files 506 511 +5
Lines 10777 10788 +11
Branches 2709 2709
==========================================
+ Hits 8624 8645 +21
+ Misses 1900 1890 -10
Partials 253 253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/styling/base.scss
Outdated
Comment on lines
2
to
8
| box-sizing: border-box; | ||
| font-family: var(--typography-font-family-sans), system-ui, -apple-system, BlinkMacSystemFont, “Segoe UI”, Roboto, sans-serif; | ||
| font-size: var(--typography-font-size-md); | ||
|
|
||
| * { | ||
| box-sizing: border-box; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| box-sizing: border-box; | |
| font-family: var(--typography-font-family-sans), system-ui, -apple-system, BlinkMacSystemFont, “Segoe UI”, Roboto, sans-serif; | |
| font-size: var(--typography-font-size-md); | |
| * { | |
| box-sizing: border-box; | |
| } | |
| font-family: var(--typography-font-family-sans), system-ui, -apple-system, BlinkMacSystemFont, “Segoe UI”, Roboto, sans-serif; | |
| font-size: var(--typography-font-size-md); |
We shouldn't need these as these should be part of the modern-normalize package.
arnautov-anton
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Add new low-level
Buttoncomponent and corresponding styles.🛠 Implementation details
We can achieve different default button styles by combining the following groups of CSS classes:
Hierarchy (in some way)
str-chat__button--primary/str-chat__button--secondary/str-chat__button--destructiveLook
str-chat__button--solid/str-chat__button--outline/str-chat__button--ghostShadow
str-chat__button--floatingButtons also change upon:
:hover:active:focus-visible:disabled🎨 UI Changes
figma