feat(p2p): add metrics for actual peer count seen by PeerManager #3162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3011
What
Adds
Functional_Peers_ConnectedandReserved_Peers_Connectedmetrics that match GraphQL peer count.Why
peer_count_per_protocolcounts at libp2p transport level, while GraphQL returns peers from PeerManager (after LimitedBehaviour filtering). Not a bug, just different abstraction levels.Changes
p2p_metrics.rsNote for infra
Grafana should use
Functional_Peers_Connectedinstead ofpeer_count_per_protocol.