Conversation
fe566a7 to
225be47
Compare
Contributor
|
I didn't look too closely at your implementation, but doesn't the spec say that structures can't have nulls? |
Contributor
|
Looks interesting. Only request I would have is to add some doc strings. Especially to Lastly need an example of how to use this. |
Member
Author
|
This is not ready for release. There is an error, and performance is an issue..... |
…or registring on the fly
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes:
#373
#293
#287
and is necessary for :
#368
This is a work in progress. Currently only parses the xml file and generate python code which can be compiled online or imported. we need to:
client:
server: