Fixed suggestions when providing generic type of self as the first parameter#529
Open
ChrisUMB wants to merge 1 commit intoEmmyLua:masterfrom
Open
Fixed suggestions when providing generic type of self as the first parameter#529ChrisUMB wants to merge 1 commit intoEmmyLua:masterfrom
self as the first parameter#529ChrisUMB wants to merge 1 commit intoEmmyLua:masterfrom
Conversation
Updated build.gradle.kts
|
@ChrisUMB , is this the same problem?: With Without |
|
@ChrisUMB , anyway, can you rebase and solve conflicts, please ? |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was an issue where if you provided a generic to a type, it would not properly suggest functions.
As you can see, if there is no generic, it properly suggests the function.
However, if there is a generic, it doesn't properly suggest the function.
This commit fixes that.
Furthermore, there was an issue where if you provided a generic type to the first parameter of a non-self function, it would not suggest it. It would suggest it if it wasn't a generic.
This commit also fixes that.
Note: I modified the gradle build file because it wouldn't properly build on my setup for some reason.