Open
Conversation
…ded to python-zocalo
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
ndevenish
requested changes
Jan 26, 2026
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ndevenish
reviewed
Feb 2, 2026
ndevenish
previously requested changes
Feb 2, 2026
….get() was being called
….get() was being called
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ndevenish
requested changes
Feb 24, 2026
ndevenish
reviewed
Feb 24, 2026
…try to self.config._opentelemetry
for more information, see https://pre-commit.ci
ndevenish
reviewed
Mar 2, 2026
ndevenish
requested changes
Mar 3, 2026
| # Configure the context depending on if service is emitting spans | ||
| stack.enter_context(log_extender("recipe_ID", recipe_id)) | ||
| if otel_logs: | ||
| stack.enter_context(log_extender("otel_logs", otel_logs)) |
Contributor
There was a problem hiding this comment.
As discussed, this puts a text repr of the dictionary in the log field a.k.a
Span and trace ID should be passed separately.
| otel_logs = { | ||
| "span_id": span_id, | ||
| "trace_id": trace_id, | ||
| "recipe_id": recipe_id, |
Contributor
There was a problem hiding this comment.
another note that this recipe_id is redundant as it is already injected onto the log message
Comment on lines
+197
to
+201
| otel_config = ( | ||
| self.config._opentelemetry | ||
| if self.config and hasattr(self.config, "_opentelemetry") | ||
| else None | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| otel_config = ( | |
| self.config._opentelemetry | |
| if self.config and hasattr(self.config, "_opentelemetry") | |
| else None | |
| ) | |
| otel_config = getattr(self.config, "_opentelemetry", None) |
| if log_extender and rw.environment and rw.environment.get("ID"): | ||
| with log_extender("recipe_ID", rw.environment["ID"]): | ||
|
|
||
| if log_extender and rw.environment["ID"]: |
Contributor
There was a problem hiding this comment.
does this need to be .get() - KeyError if "ID" is not in environment?
Contributor
There was a problem hiding this comment.
Suddenly forgetting what is and isn't assumed to be present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added OTEL Tracing to zocalo service