Skip to content

Run client callbacks in the main thread#1346

Open
tpoliaw wants to merge 1 commit intomainfrom
main-thread-callbacks
Open

Run client callbacks in the main thread#1346
tpoliaw wants to merge 1 commit intomainfrom
main-thread-callbacks

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Jan 22, 2026

Still need to handle the timeout but as a proof-of-concept for testing the plotting callback it should be a start.

@tpoliaw tpoliaw requested a review from RJCD-Diamond January 22, 2026 17:25
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.91%. Comparing base (162ef03) to head (f049ac9).

Files with missing lines Patch % Lines
src/blueapi/client/client.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1346      +/-   ##
==========================================
- Coverage   95.00%   94.91%   -0.10%     
==========================================
  Files          42       42              
  Lines        2765     2771       +6     
==========================================
+ Hits         2627     2630       +3     
- Misses        138      141       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abbiemery abbiemery marked this pull request as ready for review February 26, 2026 16:09
@abbiemery abbiemery requested a review from a team as a code owner February 26, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant