-
Notifications
You must be signed in to change notification settings - Fork 34
fix: EdDSA to Ed25519 token migration #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aldbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, thank you 🙂
I just have a few minor comments around the tests.
Next step: making sure there is a documentation page to rotate the keys (and delete old ones if needed). If it does not exist, then we need to create one based on #499 (comment)
TODOs:Rotation:
How to check rotation:
|
|
joserfc error breaking the demo when trying to login as diracAdmin:
Full Logs: See: https://jose.authlib.org/en/guide/errors/#unsupportedalgorithmerror |
cc @aldbr
Closes: #718
Changes:
TODO: