Skip to content

Log evicted WebSocket close errors instead of silently swallowing #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsarno merged 1 commit into from
Feb 20, 2026
Merged

Log evicted WebSocket close errors instead of silently swallowing #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Server/src/transport/plugin_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,8 @@ async def _evict_connection(cls, session_id: str, reason: str) -> None:
if websocket is not None:
try:
await websocket.close(code=1001)
except Exception:
pass
except Exception as close_ex:
logger.debug("Error closing evicted WebSocket for session %s: %s", session_id, close_ex)

if cls._registry is not None:
try:
Expand Down