chore(medcat-gliner): CU-869c3bvm0 Migrate gliner implementation to public #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CU-869bepjj9: Add gliner based NER * CU-869bepjj9: Depend on MedCAT v2.5 and onwards for lazy registration * CU-869bepjj9: Shuffle some code around to do registration separately * CU-869bepjj9: Fix minor logic issue * CU-869bepjj9: Add small registration test * CU-869bepjj9: Add a simple test for creator validation * CU-869bepjj9: Add workflow for gliner * CU-869bepjj9: Pin dependency to 2.0 and higher * CU-869bepjj9: Fix typing issue regards new method in v2.5 * CU-869bepjj9: Add missing dunder init file * CU-869bepjj9: Update tests to do a manual import before medcat 2.5.0 release * CU-869bepjj9: Fix minor tying issue to do with version check * CU-869bepjj9: Fix another minor tying issue to do with version check * CU-869bepjj9: Add a workaround for improper names in component classes to tests
Added a section comparing NER recall between vocab based NER and GliNER implementation using the 2023 SNOMED CT Linking Challenge dataset.
…/medcat-gliner/CU-869c3bvm0-migrate-gliner-implementation-to-public
… (for lazy registration)
Member
|
Task linked: CU-869c3bvm0 Migrate gliner NER to a public project |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…to main workflow" This reverts commit 2c15273.
tomolopolis
reviewed
Feb 11, 2026
Member
tomolopolis
left a comment
tomolopolis
left a comment
There was a problem hiding this comment.
lgtm - similar comments as #327
|
|
||
| Args: | ||
| doc (MutableDocument): | ||
| Spacy document to be annotated with named entities. |
Member
There was a problem hiding this comment.
its a spacy like document, but it might not be a real spacy doc
Member
There was a problem hiding this comment.
just do this in __init__.py directly?
Collaborator
Author
There was a problem hiding this comment.
I wanted to keep the __init__ cleaner in terms of what's in its global state. I.e so that when you import medcat_gliner you don't get some registration things that aren't really useful for a user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the gliner based implementation from
cogstack-opsto the publiccogstack-nlpwith all its history (hopefully) intact.Also added the relevant workflow(s).