Skip to content

Conversation

@abaicus
Copy link
Contributor

@abaicus abaicus commented Dec 12, 2025

All Submissions:

Changes proposed in this Pull Request:

  • Updates View all stats link to go to the dashboard;
  • Updates visits limit notice text;
  • Fixes some string issues where we used concatenated strings which loose context in different languages;
  • Fixes consistency with Optimole naming where sometimes OptiMole was used throughout different files;
  • Fixes some other text issues in the readme files.
  • Adds translations diff workflow;
image

Closes Codeinwp/optimole-service#1581.
Closes Codeinwp/optimole-service#1586.
Closes Codeinwp/optimole-service#1643.

How to test the changes in this Pull Request:

  1. Ensure that the dashboard widget View all stats link in the main dashboard page points to the Optimole dashboard metrics page;
  2. Check that the visits limit notice has the new text (see screenshot above);
  3. Check that there are no errors or missing strings in the Optimole dashboard pages;

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot
Copy link
Collaborator

pirate-bot commented Dec 12, 2025

Plugin build for 188c9b8 is ready 🛎️!

@abaicus abaicus force-pushed the enh/translations-generic branch from d79647e to 61bfd7b Compare December 12, 2025 09:51
@pirate-bot
Copy link
Collaborator

pirate-bot commented Dec 12, 2025

🌍 i18n String Review Report

📊 Summary

Category Count
➕ Added 4
➖ Removed 6
🔄 Changed 0
Total 10
➕ Added Strings (4) - Click to expand
String Location Words Suggested Match
You're nearing your %1$s-visit monthly cap on ... inc/admin.php:647 21 %3$sYour account has been disabled due to exceeding quota.%4$s All images are being redirected to the original unoptimized URL. %5$sPlease %1$supgrade%2$s to re-activate the account.
Last optimized images inc/admin.php:2284 3 optimized images
%s Saved inc/admin.php:2286 2 Saved
%s smaller inc/admin.php:2288 2 smaller
Total 28
➖ Removed Strings (6) - Click to expand
String Location
%1$sIt seems you are close to the %2$s visits l... inc/admin.php:647
Connect to OptiMole inc/admin.php:867
Last inc/admin.php:2289
Saved inc/admin.php:2290
smaller inc/admin.php:2291
optimized images inc/admin.php:2292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants