Fixed incorrect description type#1
Open
A-UNDERSCORE-D wants to merge 2 commits intoCloudBotIRC:masterfrom
Open
Fixed incorrect description type#1A-UNDERSCORE-D wants to merge 2 commits intoCloudBotIRC:masterfrom
A-UNDERSCORE-D wants to merge 2 commits intoCloudBotIRC:masterfrom
Conversation
linuxdaemon
reviewed
May 9, 2017
mcstatus/pinger.py
Outdated
| self.description_clean = re.sub(r'\u00A7.', '', raw["description"]) | ||
| # for newer versions of minecraft | ||
|
|
||
| if type(raw["description"]) is str: |
There was a problem hiding this comment.
Switching to isinstance() checks may be better, and using string_types instead of str would be more version compatible
… str for compatability
|
Even though supporting the full format (http://wiki.vg/Chat) would be best, this is definitely a step up from nothing for 1.9 at all. I'll give my vote for pulling this in, thank you for making this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer MineCraft severs respond with a different format for the description than what was originally expected, added a check for the old format and new formats, and throws an error otherwise