Add option to run compression on chunked representation #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juntyr
approved these changes
Dec 22, 2025
| ds[v], TARGET_CHUNK_SIZE, word_size=word_size | ||
| ) | ||
| ds[v] = ds[v].chunk(optimal_chunks) | ||
| # ds = ds.unify_chunks() |
Collaborator
There was a problem hiding this comment.
Why is this commented out?
Member
Author
There was a problem hiding this comment.
This line will only affect the coordinates of the dataset. I found that for the CMIP6 ta data this lead to some issue when trying to write the dataset back to disk so I just avoided rechunking the coordinates because it doesn't affect the compression process anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to compress the data with chunk sizes computed by Bryan's chunking algorithm: https://github.com/NCAS-CMS/cfs3/blob/390ee593bfea1d926d6b814636b02fb4c430f91e/cfs3/cfchunking.py .