Add missing public initializers for LSP entities#27
Merged
mattmassicotte merged 2 commits intoChimeHQ:mainfrom Apr 22, 2025
Merged
Add missing public initializers for LSP entities#27mattmassicotte merged 2 commits intoChimeHQ:mainfrom
mattmassicotte merged 2 commits intoChimeHQ:mainfrom
Conversation
Contributor
|
Wow, thank you so much! The reason this happened is that many LSP types only need to be created on servers. I'm aware of a few server implementations that are based on this library, and they have driven a lot of the need for initializers. But they are pretty rare compared to clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I noticed some issues with the library’s public API. I guess this is a consequence of the library’s past use in a mono-repo (with LanguageClient), and maybe also because some entities haven’t been used yet at all
Problem:
Some of public entities have
public letproperties and haven'tpublic initconstructors, that makes impossible to create and fill them outside library scope.Solution:
I have added initializers for all the public LSP protocol entities I found (even those with
varproperties).P.S.
I also ran
./run-swift-format.shand added changes in second commit