backport: hardening and bugfixes for main stable

[somethingwithproof]

Consolidated backport of security and bugfix PRs.

[Copilot]

Pull request overview

Consolidated backport that hardens the Syslog plugin and rolls in multiple bugfixes, with additional tooling/docs updates to support newer Cacti/PHP environments.

Changes:

• Added/updated localization assets and helper scripts for gettext generation.
• Refactored/consolidated frontend JS into js/functions.js, and expanded DB wrapper utilities.
• Added CI workflow + test data population script, plus documentation/versioning updates.

Reviewed changes

Copilot reviewed 38 out of 95 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
locales/po/es-ES.po	Adds Spanish (es_ES) translation catalog for Syslog UI strings
locales/po/ar-SA.po	Adds Arabic (ar_SA) translation catalog for Syslog UI strings
locales/index.php	Adds header block + normalizes redirect header quoting
locales/build_gettext.sh	Adds gettext build/merge/compile helper script
locales/LC_MESSAGES/index.php	Adds header block + normalizes redirect header quoting
js/functions.js	Centralizes Syslog plugin JS previously inlined in PHP
index.php	Adds header block; normalizes redirect
images/index.php	Adds header block + normalizes redirect header quoting
database.php	Expands/modernizes syslog DB wrapper API incl. prepared helpers and utility methods
contrib/snmptt-syslog-connector.py	Adds a contrib SNMPTT → syslog_incoming connector script
config_local.php.dist	Adds local syslog config template (incl. ssl/retries/install options)
config.php.dist	Extends DB config options (retries/SSL) + updates incoming field mappings
README.md	Major doc refresh: features, install notes, rsyslog examples, DB notes
LICENSE	Updates GPL text formatting/address (but currently contains conflict markers)
INFO	Updates plugin metadata (version/compat/capabilities)
CHANGELOG.md	Adds a standalone changelog capturing issues/features across versions
.mdlrc	Adds markdownlint configuration
.mdl_style.rb	Adds markdownlint style customizations
.github/workflows/populate_syslog_incoming.sh	Adds script to insert test syslog/rules data for CI
.github/workflows/plugin-ci-workflow.yml	Adds GitHub Actions workflow to run integration checks against Cacti + Syslog
.github/copilot-instructions.md	Adds repository-specific Copilot guidance for Syslog plugin development
.github/agents/triage_agent.md.agent.md	Adds agent definition doc for triage workflow
.github/agents/triage_agent.agent.md	Adds triage agent definition (duplicate/alternate)
.github/agents/php-developer.agent.md	Adds PHP developer agent definition
.github/agents/mysql-mariadb.agent.md	Adds MySQL/MariaDB DBA agent definition
.github/agents/code-quality.agent.md	Adds code-quality agent definition
.github/ISSUE_TEMPLATE/feature_request.md	Adds feature request issue template
.github/ISSUE_TEMPLATE/bug_report.md	Adds bug report issue template
.github/ISSUE_TEMPLATE/agents/php-developer.agent.md	Adds agent template copy for PHP developer
.github/ISSUE_TEMPLATE/agents/mysql-mariadb.agent.md	Adds agent template copy for MySQL/MariaDB
.github/ISSUE_TEMPLATE/agents/code-quality.agent.md	Adds agent template copy for code quality

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

The LICENSE file contains unresolved git merge conflict markers, which makes the license text invalid/distributable. Resolve the conflict and remove the markers so the file contains only the intended GPLv2 license text.

[somethingwithproof]

Fixed.

[Copilot]

This changes syslog_db_fetch_insert_id from taking a $syslog_cnn argument to taking none. In PHP 8+, existing call sites that still pass an argument will throw ArgumentCountError. To preserve backward compatibility, accept an optional parameter (or variadic) and fall back to global $syslog_cnn when not provided.

Suggested change

	* @param $syslog_cnn - the connection object to connect to
	*
	* @return the id of the last auto incriment row that was created
	*/
	function syslog_db_fetch_insert_id() {
	global $syslog_cnn;
	return db_fetch_insert_id($syslog_cnn);
	* @param object|null $syslog_cnn - (optional) the connection object to use; falls back to global $syslog_cnn when null
	*
	* @return the id of the last auto incriment row that was created
	*/
	function syslog_db_fetch_insert_id($syslog_cnn = null) {
	if ($syslog_cnn === null) {
	global $syslog_cnn;
	}
	return db_fetch_insert_id($syslog_cnn);

[somethingwithproof]

Fixed -- added optional param with null default.

[Copilot]

strURL is assigned without var/let/const, which creates/overwrites a global and can cause hard-to-trace collisions between functions. Declare it locally (e.g., var strURL = ...) to match the rest of the file.

Suggested change

	strURL = 'syslog.php?tab=stats&clear=1&header=false';
	var strURL = 'syslog.php?tab=stats&clear=1&header=false';

[somethingwithproof]

Fixed.

[Copilot]

$('#test').trigger('keyup') appears to reference an element id that is not created anywhere in this module (the search input is created as id=\"term\"). As written, this will be a no-op and likely breaks the intended refresh/search behavior. Trigger the event on the actual input that drives host filtering (e.g., the created #term element) or remove this line if no longer needed.

Suggested change

	$('#test').trigger('keyup');
	$('#term').trigger('keyup');

[somethingwithproof]

Fixed.

[Copilot]

.prop('disable', true) is not a valid way to disable inputs; the correct property is disabled. As-is, this will not actually prevent interaction and can leave the multiselect in an inconsistent state.

Suggested change

	$(this).prop('disable', true);
	$(this).prop('disabled', true);

[somethingwithproof]

Fixed.

[Copilot]

This fenced code block is malformed ( ``console instead of ```console), which breaks Markdown rendering for this section. Update it to a proper fenced block so the example displays correctly.

Suggested change

	``console
	```console

[somethingwithproof]

Fixed.

[Copilot]

After sending a Location header, it’s best practice to terminate the script (exit;) to prevent any further output/side effects (especially if additional code is ever added later). Consider adding exit; after the redirect.

Suggested change

	exit;

[somethingwithproof]

Fixed.

[Copilot]

Correct the product name in the Spanish translation from 'Cactus' to 'Cacti' to match the project name.

Suggested change

	msgstr "Error al guardar. Los recopiladores de datos remotos en modo de sincronización no pueden guardar reglas. En su lugar, guarde desde el servidor principal de Cactus."
	msgstr "Error al guardar. Los recopiladores de datos remotos en modo de sincronización no pueden guardar reglas. En su lugar, guarde desde el servidor principal de Cacti."

[somethingwithproof]

Fixed.

[Copilot]

Correct Spanish typo: 'Depuraración' → 'Depuración'.

Suggested change

	msgstr "Depuraración"
	msgstr "Depuración"

[somethingwithproof]

Fixed.

[Copilot]

PR description says this is a backport of security/bugfix PRs, but the changes include a version bump to 4.2 (and the added changelog includes multiple new features). If this PR is intended to be a pure stable backport, consider separating version/feature additions into a different PR or updating the PR description to reflect the scope.

[somethingwithproof]

Acknowledged -- this is intentionally a combined backport+version bump to align with the 4.2 release.