Fix: NullException in IPScanner Ping & NETBIOS for some addresses / cases#2964
Merged
mergify[bot] merged 4 commits intomainfrom Dec 22, 2024
Merged
Fix: NullException in IPScanner Ping & NETBIOS for some addresses / cases#2964mergify[bot] merged 4 commits intomainfrom
mergify[bot] merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request includes a series of changes to the
NETworkManagerproject, focusing on improving the IP scanner functionality and updating the UI layout. The key changes involve modifying theNetBIOSInfoclass to include an IP address, updating thePingAsyncmethod for better error handling, and adjusting the layout of list view items in theIPScannerView.xamlfile.Improvements to IP Scanner functionality:
Source/NETworkManager.Models/Network/IPScanner.cs: Updated theScanAsyncmethod to pass the IP address to theNetBIOSInfoconstructor when NetBIOS lookup is not enabled.Source/NETworkManager.Models/Network/IPScanner.cs: Enhanced thePingAsyncmethod to handle different address families using a switch statement and added error handling for unknown ping statuses.Enhancements to
NetBIOSInfoandNetBIOSResolver:Source/NETworkManager.Models/Network/NetBIOSInfo.cs: Modified theNetBIOSInfoconstructor to accept anIPAddressparameter and set it as a property.Source/NETworkManager.Models/Network/NetBIOSResolver.cs: Updated theResolveAsyncmethod to return aNetBIOSInfoobject with the IP address in various error handling scenarios. [1] [2]UI layout adjustments:
Source/NETworkManager/Views/IPScannerView.xaml: Changed the column definitions of multipleListViewItemelements to have aMinWidthof100or150and aWidthofAutofor better layout flexibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]To-Do
Contributing
By submitting this pull request, I confirm the following: