Feature: Migrate loading indicators to NETworkManager#2963
Merged
mergify[bot] merged 2 commits intomainfrom Dec 22, 2024
Merged
Feature: Migrate loading indicators to NETworkManager#2963mergify[bot] merged 2 commits intomainfrom
mergify[bot] merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide some details about this pull request:
Copilot:
Details
This pull request includes significant changes to the `NETworkManager` project, focusing on the removal of an external dependency and the introduction of a custom loading indicator control. The most important changes include the removal of `LoadingIndicators.WPF` references, the addition of new loading indicator styles, and the implementation of a custom `LoadingIndicator` control.Removal of external dependency:
Source/NETworkManager/App.xaml: Removed references toLoadingIndicators.WPFresource dictionaries.Source/NETworkManager/NETworkManager.csproj: RemovedLoadingIndicators.WPFpackage reference.Addition of custom loading indicator:
Source/NETworkManager/LoadingIndicators.cs: Implemented a customLoadingIndicatorcontrol with dependency properties forSpeedRatioandIsActive.Source/NETworkManager/Resources/Styles/LoadingIndicatorArcsStyle.xaml: Added a new style for the custom loading indicator with arc animations.Source/NETworkManager/Resources/Styles/LoadingIndicatorPulseStyle.xaml: Added a new style for the custom loading indicator with pulse animations.Namespace updates:
Source/NETworkManager/Views/DiscoveryProtocolView.xaml: Updated XAML to use the customLoadingIndicatorcontrol. [1] [2]Source/NETworkManager/Views/IPApiDNSResolverWidgetView.xaml: Updated XAML to use the customLoadingIndicatorcontrol. [1] [2]Source/NETworkManager/Views/IPApiIPGeolocationWidgetView.xaml: Updated XAML to use the customLoadingIndicatorcontrol.ToDo:
By submitting this pull request, I confirm the following: