Fix force-shown integer value not showing correct number of rows#2832
Merged
tastybento merged 1 commit intodevelopfrom Mar 8, 2026
Merged
Fix force-shown integer value not showing correct number of rows#2832tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
When force-shown is set to an integer N, mark all rows 1 through N as forced rather than only row N. The previous code caused intermediate rows to be skipped in createItemMap (which only advances its slot index for forced rows), so force-shown: 6 produced a 2-row inventory instead of 6. Fixes #2471 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force-shown: 6in a panel YAML was only marking row 6 as forced, not rows 1–6createItemMaponly advances its slot index for forced rows, so unforceed intermediate rows were skippedFix: When
force-shownis an integer N, force all rows 1 through N (indices 0 to N-1). The list form (force-shown: [2, 4]) is unchanged.Fixes #2471
Test plan
force-shown: 6and a background/border — confirm it opens with 6 rowsforce-shown: 3— confirm it opens with 3 rows minimumforce-shown: [2, 4]still forces only rows 2 and 4 individually (no regression)./gradlew test)🤖 Generated with Claude Code