Skip to content

Fix EntryUpdatedDecorator::halt() not halting its child#1112

Merged
facontidavide merged 2 commits intomasterfrom
fix/issue-1111-entry-updated-halt
Feb 5, 2026
Merged

Fix EntryUpdatedDecorator::halt() not halting its child#1112
facontidavide merged 2 commits intomasterfrom
fix/issue-1111-entry-updated-halt

Conversation

@facontidavide
Copy link
Collaborator

Summary

  • EntryUpdatedDecorator::halt() was missing the call to DecoratorNode::halt(), so the child node was never halted when the decorator was halted
  • Added the missing DecoratorNode::halt() call after resetting still_executing_child_
  • Audited all other nodes in the codebase — this was the only one with the issue

Fixes #1111

Test plan

  • Project builds successfully
  • All existing decorator tests pass
  • All pre-commit hooks (clang-format, clang-tidy, codespell) pass

🤖 Generated with Claude Code

facontidavide and others added 2 commits February 5, 2026 12:05
EntryUpdatedDecorator::halt() was missing the call to DecoratorNode::halt(),
which meant the child node was never halted when the decorator was halted.

Fixes #1111

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@facontidavide facontidavide merged commit fee8964 into master Feb 5, 2026
14 checks passed
@facontidavide facontidavide deleted the fix/issue-1111-entry-updated-halt branch February 5, 2026 11:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EntryUpdatedDecorator does not halt its children when halting

1 participant