Fix clang-tidy warnings across tests, examples, and samples

[facontidavide]

Summary

• Add anonymous namespaces for file-local static variables to prevent ODR violations
• Add Rule of Five (destructor/copy/move) for test fixtures to satisfy clang-tidy checks
• Fix implicit bool conversion (use != 0 instead of relying on implicit conversion)
• Add NOLINT comments for intentional patterns (e.g., while(true) loops)
• Initialize array elements explicitly in test helpers
• Add void casts for intentionally unused return values
• Add default member initializers where appropriate
• Update run_clang_tidy.sh to include tests directory

Test plan

• All pre-commit hooks pass (clang-format, clang-tidy, codespell)
• CI passes on all platforms

🤖 Generated with Claude Code

[facontidavide]

CI Failure Investigation

The failing tests on Windows (Groot2PublisherTest.DestructorCompletesAfterException and Groot2PublisherTest.DestructorCompletesWithMultipleNodes) are not caused by this PR.

The same failures exist on the master branch (run 21672676452):

[ RUN      ] Groot2PublisherTest.DestructorCompletesAfterException
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.
[  FAILED  ] Groot2PublisherTest.DestructorCompletesAfterException (8 ms)
[ RUN      ] Groot2PublisherTest.DestructorCompletesWithMultipleNodes
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.
[  FAILED  ] Groot2PublisherTest.DestructorCompletesWithMultipleNodes (6 ms)

This appears to be a race condition or use-after-free bug in the ZMQ shutdown handling on Windows, unrelated to the clang-tidy fixes in this PR.

Summary of passing checks:

• ✅ clang-tidy
• ✅ pre-commit
• ✅ cmake Ubuntu (ubuntu-22.04)
• ✅ cmake Ubuntu Sanitizers (asan, ubsan, tsan)
• ✅ coverage
• ✅ SonarCloud

[facontidavide]

Groot2Publisher Fix Pushed

I've pushed a fix that addresses the Windows destructor issues:

Changes:

1. Removed static used_ports tracking - This was unnecessary as ZMQ will fail to bind if a port is already in use. Removing the static variables eliminates potential cross-test/cross-process pollution.

2. Fixed move constructor/assignment - Changed from = default to = delete since the base class StatusChangeLogger already deletes move operations (violating this was technically ill-formed).

3. Explicit socket close in destructor - Added explicit _p->server.close() and _p->publisher.close() before context destruction to ensure proper cleanup on all platforms, especially Windows.

Testing:

• All 4 Groot2PublisherTest tests pass locally on Linux
• No ASAN errors in the Groot2Publisher tests
• Pre-commit (clang-format, clang-tidy, codespell) all pass

The Windows CI should now pass for the Groot2PublisherTest tests. Please monitor the CI run to verify.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud