-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat edit summary and transcript #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the functionality to edit conversation summaries and transcript segments. The changes span across the frontend UI, state management, and backend API and database layers.
My review has identified a few high-severity issues:
- In the
ConversationDetailProvider, there's a state mutation issue ingetSummarizedAppand code duplication in resource disposal logic. - In the Python backend,
update_conversation_segment_textis missing a transaction, creating a race condition risk. - There's also a regression in
get_closest_conversation_to_timestampswhere timezone-aware datetimes were replaced with naive ones, which could lead to incorrect queries.
These issues should be addressed to ensure data consistency and prevent potential bugs.
app/lib/pages/conversation_detail/conversation_detail_provider.dart
Outdated
Show resolved
Hide resolved
app/lib/pages/conversation_detail/conversation_detail_provider.dart
Outdated
Show resolved
Hide resolved
|
On the summary page, why is the Markdown not being rendered? |
It's because when I was testing those conversations lost markdown content. working on some improvements which will be more good
ScreenRecording_12-24-2025.24.MP4 |
|
dont forget to ask for my review once this pr is ready. |
|
any update? is it ready? |
closes #3526
Editing Summary:
ScreenRecording_12-24-2025.21-45-24_1.MP4
Editing Transcript:
ScreenRecording_12-24-2025.21-45-03_1.MP4