Skip to content

Conversation

@krushnarout
Copy link
Member

@krushnarout krushnarout commented Dec 14, 2025

closes #3526

Editing Summary:

ScreenRecording_12-24-2025.21-45-24_1.MP4

Editing Transcript:

ScreenRecording_12-24-2025.21-45-03_1.MP4

@krushnarout krushnarout marked this pull request as draft December 14, 2025 14:21
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the functionality to edit conversation summaries and transcript segments. The changes span across the frontend UI, state management, and backend API and database layers.

My review has identified a few high-severity issues:

  • In the ConversationDetailProvider, there's a state mutation issue in getSummarizedApp and code duplication in resource disposal logic.
  • In the Python backend, update_conversation_segment_text is missing a transaction, creating a race condition risk.
  • There's also a regression in get_closest_conversation_to_timestamps where timezone-aware datetimes were replaced with naive ones, which could lead to incorrect queries.

These issues should be addressed to ensure data consistency and prevent potential bugs.

@aaravgarg aaravgarg requested a review from mdmohsin7 December 15, 2025 16:18
@krushnarout krushnarout marked this pull request as ready for review December 16, 2025 02:38
@aaravgarg
Copy link
Collaborator

On the summary page, why is the Markdown not being rendered?

@krushnarout
Copy link
Member Author

krushnarout commented Dec 19, 2025

On the summary page, why is the Markdown not being rendered?

It's because when I was testing those conversations lost markdown content.

working on some improvements which will be more good

  • Double tap to edit (will fix accidental touch)
  • When on editing mode auto scroll should be fixed in transcript page
  • fix prevent inactive tabs from auto scrolling on search
    ^ bug exists on the main branch
ScreenRecording_12-24-2025.24.MP4

@beastoin
Copy link
Collaborator

dont forget to ask for my review once this pr is ready.

@beastoin beastoin marked this pull request as draft December 25, 2025 04:14
@mdmohsin7
Copy link
Member

any update? is it ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit Summary & Transcript

5 participants