Skip to content

Move polar plot to Python_Toolkit#315

Open
Tom-Kingstone wants to merge 2 commits intodevelopfrom
Python_Toolkit-#179-PolarCoordinatePlot
Open

Move polar plot to Python_Toolkit#315
Tom-Kingstone wants to merge 2 commits intodevelopfrom
Python_Toolkit-#179-PolarCoordinatePlot

Conversation

@Tom-Kingstone
Copy link
Contributor

NOTE: Depends on BHoM/Python_Toolkit#183

Issues addressed by this PR

Closes #311

See linked PR for more info.

Deprecated a couple of the inputs for the plot_windrose method as they no longer made any sense now that the polar plot method exists in Python_Toolkit.

Test files

Run unit tests and ensure they pass

Check the Wind class using jupyter to see that it works properly: import wind from an EPW file or openmeteo and try creating a number of different wind roses.

Changelog

  • Moved polar plot from Wind class to Python_Toolkit

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Jul 1, 2025
@Tom-Kingstone Tom-Kingstone added type:feature New capability or enhancement status:WIP PR in progress and still in draft, not ready for formal review and removed status:WIP PR in progress and still in draft, not ready for formal review labels Jul 1, 2025
@bhombot-ci
Copy link

bhombot-ci bot commented Jul 10, 2025

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial approval. I have spot tested wind rose creation manually, and wind rose created as expected.

I am having unrelated issues with my environment, so somebody else will need to run the unit tests before this PR can be fully approved.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial approval. I have spot tested wind rose creation manually, and wind rose created as expected.

I am having unrelated issues with my environment, so somebody else will need to run the unit tests before this PR can be fully approved.

@Tom-Kingstone Tom-Kingstone force-pushed the Python_Toolkit-#179-PolarCoordinatePlot branch from b37596d to 65c914b Compare February 17, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PlotWindrose from LBT_TK to Python Toolkit

2 participants