Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Renames the ACR replication routing flag to reduce confusion with registry-level regional endpoints by introducing --global-endpoint-routing on az acr replication create|update, while keeping --region-endpoint-enabled as a deprecated alias and announcing the deprecation via breaking-change infrastructure.
Changes:
- Add
--global-endpoint-routingoption (aliasing the existingregion_endpoint_enabledargument) foracr replication create|update. - Deprecate
--region-endpoint-enabledvia argument option deprecation and register upcoming breaking-change notices.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acr/_params.py |
Introduces --global-endpoint-routing option and defines the deprecated alias behavior for the old flag. |
src/azure-cli/azure/cli/command_modules/acr/_breaking_change.py |
Registers breaking-change deprecation notices for --region-endpoint-enabled on replication create/update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| help_str = "Allow routing to this replication via the global endpoint. Requests will not be routed to a" \ | ||
| " disabled replication. Data syncing will continue regardless of the routing status." |
There was a problem hiding this comment.
Allow routing to this replication via the registry global endpoint. If disabled, requests to the global endpoint will not be routed to the replica. Data syncing to the replica will continue regardless of the global endpoint routing status.
Related command
az acr replication createaz acr replication updateDescription
Customers have been confusing
--region-endpoint-enabled(per-geo-replica, controls global endpoint routing) with the registry-level--regional-endpointsflag (az acr create|update, enables regional endpoint URLs)This PR introduces
--global-endpoint-routingas the new flag foraz acr replication create|updateand deprecates--region-endpoint-enabledwith a hidden alias and breaking change announcement, to resolve customer confusion with the registry-level--regional-endpointsflag.This PR does not remove
--region-endpoint-enabled. A follow-up PR will be created before the breaking change window to complete the rename by removing the deprecated flag.Testing Guide


History Notes
[ACR]
az acr replication create|update: Add--global-endpoint-routingflag and deprecate--region-endpoint-enabledto avoid confusion with registry-level--regional-endpointsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.