Open
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a new Ubuntu 22.04 Gen2 FIPS + TrustedLaunch SIG image definition across the AgentBaker datamodel and e2e suite, enabling validation that this VHD can bootstrap successfully.
Changes:
- Introduces a new
Distroconstant for Ubuntu 22.04 Gen2 FIPS TrustedLaunch and adds it to the “available on VHD” lists. - Adds a new Ubuntu SIG image config template + mapping entry for the new distro, updating SIG config unit expectations accordingly.
- Adds an e2e VHD config entry and a new scenario test that enables Trusted Launch + FIPS 140-3 encryption capability.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/agent/datamodel/types.go | Adds new distro constant and includes it in AKSDistrosAvailableOnVHD. |
| pkg/agent/datamodel/sig_config.go | Registers the new distro in Ubuntu/containerd/gen2 distro lists and adds a SIG image definition template + mapping entry. |
| pkg/agent/datamodel/sig_config_test.go | Extends expected maintained SIG config map and updates expected Ubuntu SIG config count. |
| e2e/config/vhd.go | Adds a new e2e Image entry for the Ubuntu 2204 Gen2 FIPS TL SIG image. |
| e2e/scenario_test.go | Adds an e2e scenario validating bootstrap for the new TL+FIPS 2204 Gen2 VHD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds SIG image config and E2E for TrustedLaunch FIPS 22.04 VHD
Which issue(s) this PR fixes:
Fixes #