test: benchmark parity-base with 48-core concurrency#20703
Draft
ludamad wants to merge 2 commits intomerge-train/barretenbergfrom
Draft
test: benchmark parity-base with 48-core concurrency#20703ludamad wants to merge 2 commits intomerge-train/barretenbergfrom
ludamad wants to merge 2 commits intomerge-train/barretenbergfrom
Conversation
Parallelize six serial bottlenecks identified by BB_BENCH profiling: 1. construct_trace_data (trace_to_polynomials.cpp): Parallelize wire writes and selector writes per-block. Stage copy cycle entries per-thread to avoid races, merge sequentially after all blocks. 2. compute_permutation_mapping cycle loop (permutation_lib.hpp): Each cycle writes to disjoint (row, col) positions — wrap in parallel_for_heuristic. 3. construct_lookup_read_counts (composer_lib.hpp): Pre-compute table offsets, process tables in parallel via parallel_for. 4. construct_lookup_table_polynomials (composer_lib.hpp): Same offset pre-computation pattern, parallel table data copy. 5. construct_databus_polynomials (prover_instance.cpp): Parallelize all four databus column loops (calldata, secondary_calldata, return_data, databus_id). 6. add_ram_rom_memory_records_to_wire_4 (oink_prover.cpp): Parallelize both read and write record loops — each gate_idx is unique.
ludamad
force-pushed
the
ad/test/benchmark-parity-base-concurrency
branch
from
36ecb65 to
a4fe074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile single-threaded operations in parity-base using HARDWARE_CONCURRENCY=48 and chonk_bench with bootstrap.sh build_bench. Identify long-running operations that could benefit from parallelization or optimization.