Closed
Conversation
Contributor
There was a problem hiding this comment.
Hey there - 我已经审阅了你的改动,这里有一些反馈:
- 内联安装脚本目前把 aarch64 版的 Miniconda 安装程序(Miniconda3-py310_25.9.1-3-Linux-aarch64.sh)写死在脚本里了。建议要么在文档中说明本指南只适用于 aarch64,要么增加一个简单的架构检测逻辑(例如通过 uname -m),根据架构选择正确的安装程序。
- 由于脚本会在当前目录写入 install-py310.sh,建议在脚本末尾将其清理掉(rm install-py310.sh),或者在文档中说明会生成这个文件,以便用户知道脚本执行后会留下什么。
- Miniconda 的下载 URL 目前固定到一个特定版本并使用清华镜像;你可以考虑补充一个简短说明或备用 URL,以便境外用户使用,或者在该版本不再可用时仍有替代方案。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- 内联安装脚本目前把 aarch64 版的 Miniconda 安装程序(Miniconda3-py310_25.9.1-3-Linux-aarch64.sh)写死在脚本里了。建议要么在文档中说明本指南只适用于 aarch64,要么增加一个简单的架构检测逻辑(例如通过 uname -m),根据架构选择正确的安装程序。
- 由于脚本会在当前目录写入 install-py310.sh,建议在脚本末尾将其清理掉(rm install-py310.sh),或者在文档中说明会生成这个文件,以便用户知道脚本执行后会留下什么。
- Miniconda 的下载 URL 目前固定到一个特定版本并使用清华镜像;你可以考虑补充一个简短说明或备用 URL,以便境外用户使用,或者在该版本不再可用时仍有替代方案。帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey there - I've reviewed your changes - here's some feedback:
- The inline install script hardcodes the aarch64 Miniconda installer (Miniconda3-py310_25.9.1-3-Linux-aarch64.sh), so consider either documenting that this guide only applies to aarch64 or adding simple architecture detection logic (e.g., via uname -m) to pick the correct installer.
- Since the script writes install-py310.sh into the current directory, it would be helpful to either clean it up at the end (rm install-py310.sh) or mention that this file will be created so users understand what’s left behind.
- The Miniconda download URL is pinned to a specific version and a Tsinghua mirror; you may want to add a brief note or alternative URL for users outside mainland China or for when this specific version becomes unavailable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline install script hardcodes the aarch64 Miniconda installer (Miniconda3-py310_25.9.1-3-Linux-aarch64.sh), so consider either documenting that this guide only applies to aarch64 or adding simple architecture detection logic (e.g., via uname -m) to pick the correct installer.
- Since the script writes install-py310.sh into the current directory, it would be helpful to either clean it up at the end (rm install-py310.sh) or mention that this file will be created so users understand what’s left behind.
- The Miniconda download URL is pinned to a specific version and a Tsinghua mirror; you may want to add a brief note or alternative URL for users outside mainland China or for when this specific version becomes unavailable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
此PR已被#87 包含 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由原来的第三方PPA安装改为从miniconda安装python
Summary by Sourcery
文档:
Original summary in English
Summary by Sourcery
Documentation: