Add and use vehicle_id #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have unique ids for vehicles in the application. This solves the problem of AntennaTracker is Tracker but also antennatracker (for waf).
The vehicle id is application wide id which would uniquely identify a vehicle. Each vehicle would have attributes like display name, waf target name etc. which can be retrieved using the id.
This is currently running on custom-beta and looking good.
PS: There are still few references of vehicle_name in the codebase, (other than for showing name on UI), those will go away when the fetch_verisons.py and fetch_whitelisted_tags.py scripts will be moved to versions_fetcher module and will utilise vehicle manager directly.