Fix CommonMark 404 on index page #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix looked for data-original-href which Quarto doesn't set. New approach directly finds the broken ".md" link and fixes it to "index.html.md". Fixes #795
|
Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/810 |
The original fix logic was correct but ran too early. Quarto's JS mangles the href *after* DOMContentLoaded, so the fix had no effect. Added setTimeout to run the fix after Quarto's JS completes. Fixes #795
Contributor
|
Thanks @erikgaas. FYI this is a problem in all Quarto/nbdev projects - so even better would be to fix it at the source, if possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CommonMark link on the docs index page goes to .md instead of index.html.md, causing a 404.
The original fix script had the right logic — it uses data-original-href which Quarto preserves with the correct URL. However, it ran on DOMContentLoaded, which is before Quarto's JS mangles the href. So by the time the fix ran, the href was still correct, and then Quarto broke it afterward.
This PR adds a setTimeout so the fix runs after Quarto's JS completes.
Testing: Verified manually on the live site by running the fix logic in the browser console — confirmed the selector finds the element and the fix restores the correct href. I haven't figured out how to make local testing repro because it works fine in local Quarto builds.
Fixes #795