Skip to content

fix: acode free build#1908

Merged
RohitKushvaha01 merged 5 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:fix-acodefree
Feb 27, 2026
Merged

fix: acode free build#1908
RohitKushvaha01 merged 5 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:fix-acodefree

Conversation

@RohitKushvaha01
Copy link
Member

Fixed build error when building acode free

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@Acode-Foundation Acode-Foundation deleted a comment from greptile-apps bot Feb 27, 2026
@RohitKushvaha01
Copy link
Member Author

@greptileai

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR fixes the acode free build by properly configuring the free version with AdMob support and fixing the package name update script. The refactored updatePackage.js now correctly updates package imports in both Menu.java and AlpineDocumentProvider.java, resolving all previously reported issues including variable shadowing and writing wrong data.

Confidence Score: 5/5

  • This PR is safe to merge - it fixes critical build issues and all previous review comments have been properly addressed
  • The refactoring in updatePackage.js is well-structured with proper error handling, all previously reported bugs are fixed (variable shadowing, wrong data being written), and the code now correctly updates both required Java files
  • No files require special attention

Important Files Changed

Filename Overview
src/plugins/browser/utils/updatePackage.js Refactored to fix variable shadowing and now properly updates both Menu.java and AlpineDocumentProvider.java files - all previous issues resolved
config.xml Changed widget id from acode to acodefree for the free build variant
package.json Added admob-plus-cordova and cordova-plugin-consent for AdMob advertising support in free version
package-lock.json Lockfile updated with new AdMob dependencies
res/android/values/ic_launcher_background.xml Updated launcher and splash background colors for free version branding

Last reviewed commit: 7952711

@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft February 27, 2026 07:15
@RohitKushvaha01
Copy link
Member Author

@greptileai

@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review February 27, 2026 07:21
@RohitKushvaha01 RohitKushvaha01 changed the title fixed: acode free build fix: acode free build Feb 27, 2026
@RohitKushvaha01 RohitKushvaha01 merged commit b79dbf1 into Acode-Foundation:main Feb 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants