Skip to content

Comments

feat(plugin-api): expose isCodeMirror flag on editorManager#1892

Merged
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom
bajrangCoder:plugin-is-codemirror-flag
Feb 21, 2026
Merged

feat(plugin-api): expose isCodeMirror flag on editorManager#1892
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom
bajrangCoder:plugin-is-codemirror-flag

Conversation

@bajrangCoder
Copy link
Member

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 21, 2026

Greptile Summary

Exposes isCodeMirror boolean flag on the editorManager object, allowing plugins to detect the editor implementation at runtime. Since Acode migrated from Ace Editor to CodeMirror while maintaining Ace API compatibility, this flag helps plugins differentiate between the two implementations.

  • Added isCodeMirror property to TypeScript EditorManager interface
  • Set flag to true in the editorManager implementation
  • Added test coverage to verify the flag value

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple feature addition with proper TypeScript typing, clean implementation, and test coverage. The change is non-breaking (uses optional property), follows existing patterns, and serves a clear purpose for plugin API compatibility detection.
  • No files require special attention

Important Files Changed

Filename Overview
src/index.d.ts Added isCodeMirror optional boolean property to EditorManager interface for plugin API
src/lib/editorManager.js Set isCodeMirror: true flag in manager object to expose editor implementation type
src/test/ace.test.js Added test case to verify isCodeMirror flag equals true

Last reviewed commit: 48fde29

@bajrangCoder bajrangCoder merged commit ab2335d into Acode-Foundation:main Feb 21, 2026
5 checks passed
@bajrangCoder bajrangCoder deleted the plugin-is-codemirror-flag branch February 21, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant