[cuebot] Allow customizing the output_path for EmailSupport#2153
Open
DiegoTavares wants to merge 4 commits intoAcademySoftwareFoundation:masterfrom
Open
[cuebot] Allow customizing the output_path for EmailSupport#2153DiegoTavares wants to merge 4 commits intoAcademySoftwareFoundation:masterfrom
DiegoTavares wants to merge 4 commits intoAcademySoftwareFoundation:masterfrom
Conversation
When writing an email with outputs, EmailSupport creates a file to be attached to the email. This was previously created at the app path, which is a problem for readonly container environments (aka kubernetes). This PR allows customizing this path and also makes sure the filename is valid.
DiegoTavares
requested review from
lithorus and
ramonfigueiredo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing an email with outputs, EmailSupport creates a file to be attached to the email. This
was previously created at the app path, which is a problem for readonly container environments (aka
kubernetes). This PR allows customizing this path and also makes sure the filename is valid.