comment out not ending Semaphore test related to cats-effect#380#10
comment out not ending Semaphore test related to cats-effect#380#10halotukozak wants to merge 1 commit intoseries/3.x-avsfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR disables a non-terminating Semaphore regression test in CatsEffectIssue380Suite that’s related to typelevel/cats-effect#380, presumably to prevent the test suite from hanging.
Changes:
- Commented out the Semaphore-related test case in
CatsEffectIssue380Suite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // test("Semaphore does not block on release — typelevel/cats-effect#380") { | ||
| // val service = Executors.newSingleThreadScheduledExecutor() | ||
| // implicit val ec = ExecutionContext.global | ||
| // implicit val cs = IO.contextShift(ec) | ||
| // implicit val timer = IO.timer(ec, service) | ||
| // |
There was a problem hiding this comment.
Commenting out the whole test block makes it easy for the code to rot and is inconsistent with how this repo skips flaky/hanging tests. Prefer keeping the test compiled and explicitly skipped via ignore(...) (at the very start of the test body, before creating the executor), or remove the test entirely if it’s permanently obsolete. See existing patterns like ignore("Test is flaky...") in monix-execution/jvm/src/test/scala/monix/execution/cancelables/ChainedCancelableJVMSuite.scala:37 and monix-execution/js/src/test/scala/monix/execution/internal/AsyncSchedulerJSSuite.scala:71-73.
No description provided.