Exercises completed by NandoOU · Pull Request #25 · AT-03/coding

NandoOU · 2017-07-04T01:37:51Z

Coding Exercises

codecov-io · 2017-07-04T02:03:44Z

Codecov Report

Merging #25 into develop will increase coverage by 0.4%.
The diff coverage is 96.02%.

@@             Coverage Diff              @@
##             develop      #25     +/-   ##
============================================
+ Coverage      94.78%   95.19%   +0.4%     
- Complexity       138      207     +69     
============================================
  Files             26       39     +13     
  Lines            307      458    +151     
  Branches          50       75     +25     
============================================
+ Hits             291      436    +145     
- Misses             5        6      +1     
- Partials          11       16      +5

Impacted Files	Coverage Δ	Complexity Δ
...ndacionjala/coding/Fernando/movies/NewRelease.java	`100% <100%> (ø)`	`4 <4> (?)`
...g/fundacionjala/coding/Fernando/movies/Rental.java	`100% <100%> (ø)`	`5 <5> (?)`
...rg/fundacionjala/coding/Fernando/movies/Movie.java	`100% <100%> (ø)`	`2 <2> (?)`
...ionjala/coding/Fernando/evaporator/Evaporator.java	`100% <100%> (ø)`	`3 <3> (?)`
...acionjala/coding/Fernando/multiples/Multiples.java	`100% <100%> (ø)`	`5 <5> (?)`
...a/coding/Fernando/haghestandlowest/HighAndLow.java	`100% <100%> (ø)`	`5 <5> (?)`
...fundacionjala/coding/Fernando/movies/Children.java	`100% <100%> (ø)`	`4 <4> (?)`
...fundacionjala/coding/Fernando/movies/Customer.java	`100% <100%> (ø)`	`8 <8> (?)`
...acionjala/coding/Fernando/StringInv/StringInv.java	`100% <100%> (ø)`	`4 <4> (?)`
.../fundacionjala/coding/Fernando/movies/Regular.java	`100% <100%> (ø)`	`4 <4> (?)`
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112c303...8461702. Read the comment docs.

carledriss · 2017-07-04T22:27:41Z

src/test/java/org/fundacionjala/coding/Fernando/BankOCR/BankOCRTest.java

+        boolean actualResult = BankOCR.validAccountNumbers(value);
+
+        // then:
+        assertTrue(!actualResult);


assertFalse

carledriss · 2017-07-04T22:28:20Z

src/test/java/org/fundacionjala/coding/Fernando/CadenaInv/CadInvTest.java

+     */
+    @Test
+    public void testWhenSentenceIsEmpty() {
+        CadInv cadI = new CadInv();


@before method

carledriss · 2017-07-04T22:28:43Z

src/test/java/org/fundacionjala/coding/Fernando/CheckSum/CheckSumTest.java

+
+        // then
+        final boolean expectedResult = true;
+        assertEquals(actualResult, expectedResult);


carledriss · 2017-07-04T22:28:56Z

src/test/java/org/fundacionjala/coding/Fernando/CheckSum/CheckSumTest.java

+     */
+    @Test
+    public void testWhenSentenceISEmpty() {
+        CheckSum cs = new CheckSum();


@before method

carledriss · 2017-07-04T22:29:19Z

src/test/java/org/fundacionjala/coding/Fernando/Exam/PromTest.java

+     */
+    @Test
+    public void testPromWhenHave5Elements() {
+        Prom p = new Prom();


@before method

carledriss · 2017-07-04T22:32:33Z

src/test/java/org/fundacionjala/coding/Fernando/movies/ChildrenTest.java

+    @Test
+    public void testCalculateAmountWhenTheRentedDaysIsLessThanThree() {
+        // given:
+        Children childrenInstance = new Children("Toy Story");


Movie childrenInstance = new Children("Toy Story");

@before method

carledriss · 2017-07-06T22:21:46Z

@NandoOU
Please update your branch against develop

carledriss · 2017-07-06T22:22:28Z

src/main/java/org/fundacionjala/coding/Fernando/StringInv/StringInv.java

+ */
+public final class StringInv {
+
+    static final int CANT_MAJOR = 5;


CANT_MAJOR ?

carledriss · 2017-07-06T22:23:36Z

src/main/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCR.java

+     * @return String to get the all numbers.
+     */
+    public static String parseDigit(final String[] cad) {
+        String res = "";


Do we need this variable?

carledriss · 2017-07-06T22:24:26Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Children.java

+     */
+    @Override
+    public int calculateFrequentRenterPoints(final int daysRented) {
+        return 1;


Use a constant for that

carledriss · 2017-07-06T22:24:43Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Customer.java

+     * @return the string.
+     */
+    public String generateDetail() {
+        StringBuffer result = new StringBuffer();


Consider using a StringBuilder

carledriss · 2017-07-06T22:25:06Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Customer.java

+        StringBuffer result = new StringBuffer();
+        result.append("Rental Record for " + getName() + "\n");
+        for (Rental rental : rentalsCustomer) {
+            result.append("\t" + rental.getMovie().getTitle() + "\t");


Don't concatenate strings using +
Consider using a String format

carledriss · 2017-07-06T22:25:40Z

src/test/java/org/fundacionjala/coding/Fernando/average/AverageTest.java

+ */
+public class AverageTest {
+
+    private Average p;


what does mean p ?

carledriss · 2017-07-06T22:26:01Z

src/test/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCRTest.java

+        };
+
+        // when:
+        String actualResult = BankOCR.parseDigit(data);


this should be final

carledriss · 2017-07-06T22:26:09Z

src/test/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCRTest.java

+        String actualResult = BankOCR.parseDigit(data);
+
+        // then:
+        String expectedResult = "0123456789";


same as above

carledriss · 2017-07-06T22:26:30Z

src/test/java/org/fundacionjala/coding/Fernando/checkSum/CheckSumTest.java

+
+        // then
+        final boolean expectedResult = true;
+        assertEquals(actualResult, expectedResult);


carledriss · 2017-07-06T22:26:39Z

src/test/java/org/fundacionjala/coding/Fernando/checkSum/CheckSumTest.java

+
+        // then
+        final boolean expectedResult = false;
+        assertEquals(actualResult, expectedResult);


assertFalse

carledriss · 2017-07-06T22:27:17Z

src/test/java/org/fundacionjala/coding/Fernando/movies/ChildrenTest.java

+
+        // then
+        final double expectedResult = 1.5;
+        assertEquals(0, expectedResult, actualResult);


first argument should be expectedResult and the second the actualResult

carledriss · 2017-07-06T22:27:26Z

src/test/java/org/fundacionjala/coding/Fernando/movies/ChildrenTest.java

+
+        // then:
+        final double expectedResult = 10.5;
+        assertEquals(0, expectedResult, actualResult);


Same as above

carledriss · 2017-07-08T16:32:01Z

src/main/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCR.java

+     * @return boolean valor if is valid account number.
+     */
+    public static boolean validAccountNumbers(final String input) {
+        int suma = 0;


carledriss · 2017-07-08T16:32:36Z

src/main/java/org/fundacionjala/coding/Fernando/movies/NewRelease.java

+ */
+public class NewRelease extends Movie {
+
+    private static final int LIMITNEWCHILD = 3;


LIMITNEWCHILD ?

carledriss · 2017-07-08T16:32:50Z

src/main/java/org/fundacionjala/coding/Fernando/movies/NewRelease.java

+    /**
+     * @param daysRented param.
+     * @return double value.
+     */


{@inherentDoc}

carledriss · 2017-07-08T16:33:02Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Regular.java

+
+    private static final double PRICE = 1.5;
+
+    private static final int LIMITREGULAR = 2;


LIMITREGULAR ?

carledriss · 2017-07-08T16:33:12Z

src/main/java/org/fundacionjala/coding/Fernando/movies/NewRelease.java

+    /**
+     * @param daysRented param.
+     * @return Children value.
+     */


{@inherentdoc}

carledriss · 2017-07-08T16:33:19Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Regular.java

+    /**
+     * @param daysRented param.
+     * @return double value.
+     */


{@inherentdoc}

carledriss · 2017-07-08T16:33:23Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Regular.java

+    /**
+     * @param daysRented param.
+     * @return int value.
+     */


{@inherentdoc}

carledriss · 2017-07-08T16:33:34Z

src/main/java/org/fundacionjala/coding/Fernando/movies/Regular.java

+     */
+    @Override
+    public int calculateFrequentRenterPoints(final int daysRented) {
+        return 1;


use a constant

carledriss · 2017-07-08T16:34:23Z

src/test/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCRTest.java

+import java.lang.reflect.Constructor;
+import java.lang.reflect.Modifier;
+
+import static junit.framework.TestCase.assertTrue;


import static org.junit.Assert.assertTrue; ?

carledriss · 2017-07-08T16:34:33Z

src/test/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCRTest.java

+    @Test
+    public void testToGetNumber() {
+        // given:
+        String[] data = {


carledriss · 2017-07-08T16:34:51Z

src/test/java/org/fundacionjala/coding/Fernando/bankOCR/BankOCRTest.java

+        String data = "021453789";
+
+        // when:
+        String actualResult = BankOCR.accountStatus(data);


carledriss · 2017-07-08T16:35:39Z

src/test/java/org/fundacionjala/coding/Fernando/movies/NewReleaseTest.java

+
+        // then
+        final double expectedResult = 1.5;
+        assertEquals(0, expectedResult, actualResult);


what is wrong here?

NandoOU and others added 18 commits March 20, 2017 20:26

prueba

ef5110c

prueba2

0698ce8

Merge remote-tracking branch 'origin/develop' into develop

e37da55

BankOCR

d4e4a06

BankOCRTest

5cb04dd

CadenaInvertida

7709f6d

CheckSum

f5037a4

CadInvTest

8f1c8c6

CheckSumTest

aafc87c

Exam

6968c4c

ExamTest

bd6795e

NuevoCheckSum

d5fb9ff

Movies

afb9a0e

MoviesTest

23ffe78

Exercises Completed

0ea81f7

Evaporator kata

c43dfe6

Exercises Completed

d00854b

Exercises Completed

caf5b8c

NandoOU added 2 commits July 3, 2017 23:21

Exercises Completed

7caa361

Exercises Completed

2cf89a4

carledriss reviewed Jul 4, 2017

View reviewed changes

NandoOU added 2 commits July 5, 2017 18:05

Coding Exercises Refactored

514ded9

Coding Exercises Refactored

fc07e38

carledriss reviewed Jul 6, 2017

View reviewed changes

NandoOU and others added 6 commits July 6, 2017 23:23

Coding Refactored

5686de4

Merge branch 'develop' into ExercisesCompleted

afcf1ce

Coding Exercises Completed

5675732

Coding Exercises Completed

4fd56f0

Coding Exercises Completed

8373efc

Coding Exercises Completed

8461702

carledriss reviewed Jul 8, 2017

View reviewed changes


		private static final double PRICE = 1.5;

		private static final int LIMITREGULAR = 2;

Conversation

NandoOU commented Jul 4, 2017

Uh oh!

codecov-io commented Jul 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carledriss commented Jul 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Jul 4, 2017 •

edited

Loading