Skip to content

fix: use explicit memory type for date/location classification. Fixes #1229#1232

Closed
ajithhraj wants to merge 1 commit intoAOSSIE-Org:mainfrom
ajithhraj:codex/issue-1229-memory-type-classification
Closed

fix: use explicit memory type for date/location classification. Fixes #1229#1232
ajithhraj wants to merge 1 commit intoAOSSIE-Org:mainfrom
ajithhraj:codex/issue-1229-memory-type-classification

Conversation

@ajithhraj
Copy link

Addressed Issues:

Fixes #1229

Screenshots/Recordings:

Not applicable.

Additional Notes:

This PR fixes date-based memories being misclassified as location memories in the frontend.

Changes made:

  • added the optional type field to the frontend Memory interface
  • updated MemoryCard to use memory.type === 'date' instead of inferring from coordinates
  • updated MemoryDetail to use the explicit memory type
  • updated MemoriesPage counts and filters to rely on the explicit memory type

This keeps the UI aligned with the backend contract instead of depending on coordinate sentinel values.

Verification:

I verified the targeted frontend logic and diff locally.

I could not complete a full frontend build in this checkout because the local frontend environment is missing required React/Redux typings and packages, and npm run build fails across the frontend for unrelated setup reasons.

AI Usage Disclosure:

  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have reviewed the code locally and I am responsible for it.

I have used the following AI models and tools: OpenAI Codex (GPT-5)

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions.
  • I have reviewed my code before submitting.
  • I have tested what I could locally.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Warning

Rate limit exceeded

@ajithhraj has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b04a4d2-1ac0-4cbe-a8a8-d8357de27f02

📥 Commits

Reviewing files that changed from the base of the PR and between 8274ebd and 29389ee.

📒 Files selected for processing (4)
  • frontend/src/api/api-functions/memories.ts
  • frontend/src/components/Memories/MemoriesPage.tsx
  • frontend/src/components/Memories/MemoryCard.tsx
  • frontend/src/components/Memories/MemoryDetail.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SIDDHANTCOOKIE
Copy link

Closing this as unreviewed issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: date-based memories are misclassified as location memories

2 participants