fix: use explicit memory type for date/location classification. Fixes #1229#1232
fix: use explicit memory type for date/location classification. Fixes #1229#1232ajithhraj wants to merge 1 commit intoAOSSIE-Org:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing this as unreviewed issue |
Addressed Issues:
Fixes #1229
Screenshots/Recordings:
Not applicable.
Additional Notes:
This PR fixes date-based memories being misclassified as location memories in the frontend.
Changes made:
typefield to the frontendMemoryinterfaceMemoryCardto usememory.type === 'date'instead of inferring from coordinatesMemoryDetailto use the explicit memory typeMemoriesPagecounts and filters to rely on the explicit memory typeThis keeps the UI aligned with the backend contract instead of depending on coordinate sentinel values.
Verification:
I verified the targeted frontend logic and diff locally.
I could not complete a full frontend build in this checkout because the local frontend environment is missing required React/Redux typings and packages, and
npm run buildfails across the frontend for unrelated setup reasons.AI Usage Disclosure:
I have used the following AI models and tools: OpenAI Codex (GPT-5)
Checklist