Conversation
bf93cb2 to
4cc2777
Compare
4cc2777 to
f1a831d
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update enables FP8 quantization support for DeepSeek batch split configurations.
When quantization is active, the following changes apply:
Kernel Quantization: gmm kernels allow FP8 recipes (defined via the MaxText command line) in both forward and backward passes.
gmmWeight All-Gathers: gmm weight all-gathers are now quantized along non-expert, non-tensor, and non-tensor_transpose axes.Note: Quantization for dispatch all-gathers is currently out of scope and will be implemented in a follow-up PR.
Tests
Verification: Validated via end-to-end (e2e) perf and convergence benchmarks.
Coverage: Unit tests will be added in a subsequent update.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.