-
Notifications
You must be signed in to change notification settings - Fork 27
Propagate dtype to final benchmark result #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f0fbb4 to
7df8f7d
Compare
chishuen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @linamy85 , seems the final report still does not have the data type for gemm_multiple_run. Can you check again? Thank you |
|
Hi @junjieqian , I can see the |
|
Hi @linamy85 thanks for checking this! We actually did not look into the csv file but only from the stdout logs, which does not include the dtype. |
|
@junjieqian To make sure we're aligned, would I feel like for result gathering, it's the easier if we could rely on final tsv file. Though I know it's quite difficult at the moment due to the lack of GCS support. log for single run |
As requested in [another PR](#84 (comment)) for easier result inspection.
This change propagates
dtypefrom the benchmark function arguments to final reporting results. This impacts benchmarks that were missing such metadata, including: