feat: Support batch import for Docker images #11640
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
agent/app/service/image.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| defer client.Close() |
There was a problem hiding this comment.
client, err := docker.NewDockerClient()
if err != nil {
return err
}
defer client.Close()
It is advisable to move this part of the code outside the loop to avoid duplication.
There was a problem hiding this comment.
Done. Moved Docker client creation outside the loop.
| </div> | ||
| <div class="file-list-bottom"> | ||
| <div v-if="selectRow?.path"> | ||
| <!-- Single select mode --> |
There was a problem hiding this comment.
recommend removing the code comments.
2 participants
What this PR does / why we need it?
Refs #11634
Summary of your change
Backend (Agent):
Frontend:
Please indicate you've done the following: