Replace ArrayBuffer with List

Author: gkepka

github/git/Commit.scala

@@ -5,12 +5,13 @@ import scala.util.Try
 
 case class Commit(author: String, sha: String, date: String)
 object Commit:
-    def commitsFromJson(json: String): ArrayBuffer[Commit] =
-        for commit <- ujson.read(json).arr 
+    def commitsFromJson(json: String): List[Commit] =
+        for commit <- ujson.read(json).arr.toList
         yield
             val author = Try(commit("author")("login").str)
                         .orElse(Try(commit("commit")("author")("name").str))
                         .getOrElse("Unknown")
             val sha = commit("sha").str
             val date = Try(commit("commit")("author")("date").str).getOrElse("")
                 Commit(author, sha, date)
+            

github/git/Repo.scala

@@ -5,7 +5,6 @@ import sttp.client3._
 import sttp.model._
 import os.Path
 
-import scala.collection.mutable.ArrayBuffer
 import scala.util.Try
 import scala.util.Success
 
@@ -17,7 +16,7 @@ class Repo(val owner: String, val repoName: String):
     lazy val localRepo = cloneRepo()
     val client = SimpleHttpClient()
 
-    def getCommits(page: Int = 1): ArrayBuffer[Commit] = 
+    def getCommits(page: Int = 1): List[Commit] = 
         val request = basicRequest
             .header("Accept", "application/vnd.github+json")
             .get(uri"https://api.github.com/repos/$owner/$repoName/commits?per_page=100&page=$page")
@@ -28,7 +27,7 @@ class Repo(val owner: String, val repoName: String):
             case Left(value) => error(value)
 
         val commits = Commit.commitsFromJson(json)
-        if (isLast(response)) commits else commits ++= getCommits(page + 1)
+        if (isLast(response)) commits else commits ++ getCommits(page + 1)
 
     def getContributors(): List[Contributor] = 
         getCommits()
@@ -37,7 +36,7 @@ class Repo(val owner: String, val repoName: String):
             .map((author, commits) => Contributor(author, commits))
             .toList
 
-    def getOpenIssuesWithoutAnswers(page: Int = 1): ArrayBuffer[Uri] = 
+    def getOpenIssuesWithoutAnswers(page: Int = 1): List[Uri] = 
         val request = basicRequest
             .header("Accept", "application/vnd.github+json")
             .get(uri"https://api.github.com/repos/$owner/$repoName/issues?per_page=100&page=$page")
@@ -47,13 +46,14 @@ class Repo(val owner: String, val repoName: String):
             case Right(content) => content
             case Left(value) => error(value)
 
-        val issues = for issue <- ujson.read(json).arr
-        if issue("state").str == "open"
-        if Try(issue("pull_request")).isFailure
-        if hasNoComments(issue("comments_url").str)
-        yield uri"${issue("html_url").str}"
+        val issues = 
+            for issue <- ujson.read(json).arr.toList
+                if issue("state").str == "open" 
+                if Try(issue("pull_request")).isFailure
+                if hasNoComments(issue("comments_url").str)
+            yield uri"${issue("html_url").str}"
 
-        if (isLast(response)) issues else issues ++= getOpenIssuesWithoutAnswers(page + 1)
+        if (isLast(response)) issues else issues ++ getOpenIssuesWithoutAnswers(page + 1)
 
     def lineCountPerLanguage(): Map[Lang, Int] = 
         os.walk(localRepo, skip = _.last.equals(".git"))

github/test/RepoTest.scala

@@ -1,7 +1,6 @@
 import munit._
 import git._
 import git.Lang.*
-import scala.collection.mutable.ArrayBuffer
 
 class RepoTest extends munit.FunSuite:
     test("getCommits") {
@@ -10,7 +9,7 @@ class RepoTest extends munit.FunSuite:
         // when
         val commitsObtained = repo.getCommits()
         // then
-        val commitsExpected = ArrayBuffer(
+        val commitsExpected = List(
             Commit("octocat", "d0dd1f61b33d64e29d8bc1372a94ef6a2fee76a9", "2014-02-12T23:20:44Z"),
             Commit("octocat", "bb4cc8d3b2e14b3af5df699876dd4ff3acd00b7f", "2014-02-04T22:38:36Z"),
             Commit("octocat", "a30c19e3f13765a3b48829788bc1cb8b4e95cee4", "2014-02-04T22:38:24Z")