Remove created array during honeypot check

I spotted some increased CPU usage that was introduced around when this merged, bit of a shot in the dark here.

Author: vcarl

app/discord/honeypotTracker.ts

@@ -37,6 +37,7 @@ export async function startHoneypotTracking(client: Client) {
       throw Error("Missing guild info when tracking honeypot messages");
     }
     let config: HoneypotConfig[];
+    const { guild } = msg;
     const cacheEntry = configCache[msg.guildId];
     if (!cacheEntry || cacheEntry.cachedAt + CACHE_TTL_IN_MS < Date.now()) {
       config = await db
@@ -55,69 +56,71 @@ export async function startHoneypotTracking(client: Client) {
       config = cacheEntry.config;
     }
 
-    const channelIds = config.map((entry) => entry.channel_id);
-    if (channelIds.includes(msg.channelId)) {
-      const [member, message] = await Promise.all([
-        msg.guild.members.fetch(msg.author.id).catch((_) => undefined),
-        msg.fetch().catch((_) => undefined),
-      ]);
-      if (!member || !message) {
-        log(
-          "debug",
-          "HoneypotTracker",
-          "unable to resolve member or message for honeypot",
-        );
-        throw Error("unable to resolve member or message for honeypot");
-      }
-      // Get moderator role for permission check
-      const { moderator: modRoleId } = await fetchSettings(msg.guildId, [
-        SETTINGS.moderator,
-      ]);
-      if (
-        (Array.isArray(member.roles)
-          ? member.roles.includes(modRoleId)
-          : member.roles.cache.has(modRoleId)) ||
-        member.permissions.has("Administrator")
-      ) {
-        log(
-          "debug",
-          "HoneypotTracker",
-          "Mod posted in Honeypot channel, no action taken",
-        );
-        return;
-      }
-      try {
-        // softban user (ban/unban) to clear all recent messages
-        await member.ban({
-          reason: "honeypot spam detected",
-          deleteMessageSeconds: 604800, // 7 days
-        });
-        await msg.guild.members.unban(member);
-        // log action
-        await reportUser({
-          reason: ReportReasons.spam,
-          message: message,
-          staff: client.user ?? false,
-        });
-      } catch (e) {
-        log(
-          "error",
-          "HoneypotTracker",
-          "Failed to softban user in honeypot channel",
-          {
-            guildId: msg.guildId,
-            userId: member.id,
-            channelId: msg.channelId,
-            error: e instanceof Error ? e.message : String(e),
-          },
-        );
-        await reportUser({
+    if (!config.some((c) => c.channel_id === msg.channelId)) {
+      return;
+    }
+    const [member, message] = await Promise.all([
+      guild.members.fetch(msg.author.id).catch((_) => undefined),
+      msg.fetch().catch((_) => undefined),
+    ]);
+    if (!member || !message) {
+      log(
+        "debug",
+        "HoneypotTracker",
+        "unable to resolve member or message for honeypot",
+      );
+      throw Error("unable to resolve member or message for honeypot");
+    }
+    // Get moderator role for permission check
+    const { moderator: modRoleId } = await fetchSettings(msg.guildId, [
+      SETTINGS.moderator,
+    ]);
+    if (
+      (Array.isArray(member.roles)
+        ? member.roles.includes(modRoleId)
+        : member.roles.cache.has(modRoleId)) ||
+      member.permissions.has("Administrator")
+    ) {
+      log(
+        "debug",
+        "HoneypotTracker",
+        "Mod posted in Honeypot channel, no action taken",
+      );
+      return;
+    }
+    try {
+      // softban user (ban/unban) to clear all recent messages
+      await Promise.all([
+        member
+          .ban({
+            reason: "honeypot spam detected",
+            deleteMessageSeconds: 604800, // 7 days
+          })
+          .then(() => guild.members.unban(member)),
+        reportUser({
           reason: ReportReasons.spam,
           message: message,
           staff: client.user ?? false,
-          extra: `Failed to softban user in honeypot channel: ${e instanceof Error ? e.message : String(e)}`,
-        });
-      }
+        }),
+      ]);
+    } catch (e) {
+      log(
+        "error",
+        "HoneypotTracker",
+        "Failed to softban user in honeypot channel",
+        {
+          guildId: msg.guildId,
+          userId: member.id,
+          channelId: msg.channelId,
+          error: e,
+        },
+      );
+      await reportUser({
+        reason: ReportReasons.spam,
+        message: message,
+        staff: client.user ?? false,
+        extra: `Failed to softban user in honeypot channel: ${e instanceof Error ? e.message : String(e)}`,
+      });
     }
   });
 }